Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from from rootfs.tar system files #978

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jjcarstens
Copy link
Member

@jjcarstens jjcarstens commented May 27, 2024

Starts support to allow building firmware from a rootfs.tar tarball file more efficiently in Elixir, rather than relying on bash scripts to unsquash, combine, and resquash an FS.

The mix firmware task was due for a good refactoring, so it looks like a lot. The old way of building is maintained for the typical rootfs.squashfs file that systems have traditionally provided.

It also adjusts the build process to allow using EROFS instead of squashfs when making the firmware

Note

This adds config :nerves, :firmware, fs_type: :erofs to specify to use EROFS. If there is a preferred option name and/or location, let me know

Other pieces to still consider:

@jjcarstens jjcarstens requested a review from fhunleth May 27, 2024 00:47
@jjcarstens jjcarstens changed the title Support squashfs and erofs filesytems for firmware Build from from rootfs.tar system files May 27, 2024
@jjcarstens jjcarstens force-pushed the firmware-build-from-tar branch 2 times, most recently from 3090116 to a19d3d5 Compare May 27, 2024 01:01
@fhunleth
Copy link
Member

Cool! Thank you. I believe tar_merger is still private so I'll copy over and rename. It has a number of deficiencies that I forgot to tell you about but it's getting close and this will definitely help me.

@jjcarstens jjcarstens force-pushed the firmware-build-from-tar branch from a19d3d5 to 0c20641 Compare May 27, 2024 01:36
@jjcarstens
Copy link
Member Author

I added a few more notes. This could probably be split into 2 PRs for the EROFS concern, but after the redact that piece is so small that it could really go either way ¯_(ツ)_/¯

I've tested manually, but probably worth adding some tests if I can think of a good way how

Starts support to allow building firmware from a `rootfs.tar` tarball file more
efficiently in Elixir, rather than relying on bash scripts to unsquash,
combine, and resquash an FS.

It also adjusts the build process to allow using EROFS instead of squashfs when
making the firmware
@jjcarstens jjcarstens force-pushed the firmware-build-from-tar branch from 0c20641 to 320e9ab Compare May 27, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants